Fix crash on https servers, version 0.1.2 #32
No reviewers
Labels
No labels
accessibility
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
mett/cushion!32
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/tls-crypto-provider"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
0.1.1 crashes (SIGABRT) about half a minute after signing in to a server over https:
The updater plugin (M9) enables rustls'
ringbackend, reqwest enablesaws-lc-rs. With both compiled in rustls can't pick a default, and the socket'swss://connection (tokio-tungstenite) panics when it builds its TLS config. reqwest names its provider itself, so signing in worked and only the socket crashed. The test server is plain http, so no test caught it.tls::init()installs aws-lc-rs as the process default at the start ofrun()(directrustlsdependency with the same features; no new crates in the lockfile).tests/tls.rsopens awss://connection to a local listener: it panics with the message above withoutinit()and passes with it.Tests: cargo fmt, clippy
-D warnings, fullcargo testagainst the test server (all pass), bindings unchanged, prettier on the changed files. Not run: a release build against a real https server.🤖 Generated with Claude Code